API maps #413
Merged
API maps #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View Playwright Report (note: open the "playwright-report" artifact) |
djahandarie
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
Wow, this is amazing, I didn't even know typescript could do type-level operations that are this complicated. 😅 It can be in a later PR, but I think some comments in api-map.d.ts would be useful for future reader trying to understand what is going on in there. I don't think it needs to be detailed, just a basic explanation of what it's trying to achieve.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step towards making serialized API interfaces more type safe, as mentioned in #391.
This has some TypeScript black magic in it, but it basically amounts to describing all APIs on a TypeScript type and then using some common mapping types. For now, this is only set up to work for
Offscreen, but should be able to be expanded upon.It ensures type safety in the
ApiMapInittype, which is used to initialize API maps. This pattern was already seen throughout the application, but with more lenient type checks, and mistakes could still be made.